Update CARGO environment variable if it is set to a rustup proxy#4275
Merged
rami3l merged 2 commits intorust-lang:masterfrom Apr 4, 2025
Merged
Update CARGO environment variable if it is set to a rustup proxy#4275rami3l merged 2 commits intorust-lang:masterfrom
CARGO environment variable if it is set to a rustup proxy#4275rami3l merged 2 commits intorust-lang:masterfrom
Conversation
rami3l
approved these changes
Apr 4, 2025
Member
rami3l
left a comment
rami3l
left a comment
There was a problem hiding this comment.
Thanks!
Not a blocker, but do we have a way to reliably test this though?
rami3l
reviewed
Apr 4, 2025
Member
Author
Hm. Not easily without some bigger changes to the testing framework... actually I guess I can manually create a symlink to a mock cargo in a test. That might work. |
ChrisDenton
force-pushed
the
no-proxy-env
branch
2 times, most recently
from
39b63e7 to
a5f27cc
Compare
djc
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done only if we know the absolute path to the real
cargoand only if we're sure thatCARGOpoints to a proxy.Fixes #4274