Skip to content

Emit tracing events from log facade calls#4310

Merged
djc merged 1 commit intomasterfrom
tracing-log
Apr 25, 2025
Merged

Emit tracing events from log facade calls#4310
djc merged 1 commit intomasterfrom
tracing-log

Conversation

@djc
Copy link
Copy Markdown
Contributor

@djc djc commented Apr 25, 2025

No description provided.

@djc djc requested review from ChrisDenton and rami3l April 25, 2025 10:19
Copy link
Copy Markdown
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I should have remembered adding that back in v1.28.0, thanks!

What does the output look like with this line BTW?

@djc djc enabled auto-merge April 25, 2025 10:25
@rami3l rami3l added this to the 1.28.2 milestone Apr 25, 2025
@djc djc added this pull request to the merge queue Apr 25, 2025
Merged via the queue into master with commit b0fc3db Apr 25, 2025
29 checks passed
@djc djc deleted the tracing-log branch April 25, 2025 11:16
@djc
Copy link
Copy Markdown
Contributor Author

djc commented Apr 25, 2025

What does the output look like with this line BTW?

A lot of stuff:

2025-04-25T10:19:42.235617Z TRACE run_rustup:run_rustup_inner:main:update_extra:install:update_from_dist: rustls::client::hs: Sending ClientHello Message {
    version: TLSv1_0,
    payload: Handshake {
        parsed: HandshakeMessagePayload {
            typ: ClientHello,
            payload: ClientHello(
                ClientHelloPayload {
                    client_version: TLSv1_2,
                    random: 06fcf773ae745a06d663b26cbb8bd1c2223f1cf02d454d46826d53d22a09d24d,
                    session_id: 6b4c236254ed285eb1c8ef87b3cc276ec82cbd3c7ac8fea5bba99f6c4b906746,
                    cipher_suites: [
                        TLS13_AES_256_GCM_SHA384,
                        TLS13_AES_128_GCM_SHA256,
                        TLS13_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
                        TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
                        TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
                        TLS_EMPTY_RENEGOTIATION_INFO_SCSV,
                    ],
                    compression_methods: [
                        Null,
                    ],
                    extensions: [
                        NamedGroups(
                            [
                                X25519,
                                secp256r1,
                                secp384r1,
                                X25519MLKEM768,
                            ],
                        ),
                        ExtendedMasterSecretRequest,
                        SupportedVersions(
                            [
                                TLSv1_3,
                                TLSv1_2,
                            ],
                        ),
                        KeyShare(
                            [
                                KeyShareEntry {
                                    group: X25519,
                                    payload: c8c880d4db52d4b65994d69ae156fb014974b4936fc9650b88a8908ee737d278,
                                },
                            ],
                        ),
                        ServerName(
                            [
                                ServerName {
                                    typ: HostName,
                                    payload: HostName(
                                        DnsName(
                                            "static.rust-lang.org",
                                        ),
                                    ),
                                },
                            ],
                        ),
                        SignatureAlgorithms(
                            [
                                ECDSA_NISTP384_SHA384,
                                ECDSA_NISTP256_SHA256,
                                ECDSA_NISTP521_SHA512,
                                ED25519,
                                RSA_PSS_SHA512,
                                RSA_PSS_SHA384,
                                RSA_PSS_SHA256,
                                RSA_PKCS1_SHA512,
                                RSA_PKCS1_SHA384,
                                RSA_PKCS1_SHA256,
                            ],
                        ),
                        PresharedKeyModes(
                            [
                                PSK_DHE_KE,
                            ],
                        ),
                        EcPointFormats(
                            [
                                Uncompressed,
                            ],
                        ),
                        CertificateStatusRequest(
                            Ocsp(
                                OcspCertificateStatusRequest {
                                    responder_ids: [],
                                    extensions: ,
                                },
                            ),
                        ),
                        PresharedKey(
                            PresharedKeyOffer {
                                identities: [
                                    PresharedKeyIdentity {
                                        identity: a35a671fc452f989da45cf33cab31d25ace12a56d70b6a96989f95fe637af13c6a9dec060ce53cf509965b434e38100690f5e0bdd06adf28a56cafb3e9c4df303df63d52f9829705d1e2da9f176e1f40563ca317198bba95189740c1123badbaabeb88e17007f6bf34399a84be3282380eee52ba5da17a9a89aaa204a210828c7558bf5bf6a875796723d87e29ca17a311ddb880ec4c9ba02f98f213ece3284f,
                                        obfuscated_ticket_age: 1943311030,
                                    },
                                ],
                                binders: [
                                    PresharedKeyBinder(
                                        29d71b834244425eb33f8dcbeaa29921ee8dbcc78944c0372a40a318b11392e3,
                                    ),
                                ],
                            },
                        ),
                    ],
                },
            ),
        },
        encoded: 010001bd030306fcf773ae745a06d663b26cbb8bd1c2223f1cf02d454d46826d53d22a09d24d206b4c236254ed285eb1c8ef87b3cc276ec82cbd3c7ac8fea5bba99f6c4b9067460014130213011303c02cc02bcca9c030c02fcca800ff01000160000a000a0008001d0017001811ec00170000002b00050403040303003300260024001d0020c8c880d4db52d4b65994d69ae156fb014974b4936fc9650b88a8908ee737d2780000001900170000147374617469632e727573742d6c616e672e6f7267000d001600140503040306030807080608050804060105010401002d00020101000b00020100000500050100000000002900cb00a600a0a35a671fc452f989da45cf33cab31d25ace12a56d70b6a96989f95fe637af13c6a9dec060ce53cf509965b434e38100690f5e0bdd06adf28a56cafb3e9c4df303df63d52f9829705d1e2da9f176e1f40563ca317198bba95189740c1123badbaabeb88e17007f6bf34399a84be3282380eee52ba5da17a9a89aaa204a210828c7558bf5bf6a875796723d87e29ca17a311ddb880ec4c9ba02f98f213ece3284f73d492b600212029d71b834244425eb33f8dcbeaa29921ee8dbcc78944c0372a40a318b11392e3,
    },
}     current_dir="/Users/djc/src/rustup" args="[\"./target/debug/rustup\", \"update\", \"beta\"]" profile="Default" prefix="/Users/djc/.rustup/toolchains/beta-aarch64-apple-darwin"
2025-04-25T10:19:42.253717Z TRACE run_rustup:run_rustup_inner:main:update_extra:install:update_from_dist: rustls::client::hs: We got ServerHello ServerHelloPayload {
    extensions: [
        SupportedVersions(
            TLSv1_3,
        ),
        KeyShare(
            KeyShareEntry {
                group: X25519,
                payload: 0954b09b7e0dd20fbd4001d426637575f0bb1a31e422adfa972eb2b7f7ff4567,
            },
        ),
        PresharedKey(
            0,
        ),
    ],
    legacy_version: TLSv1_2,
    random: bd99426f83e6c6b40b5ef0ab575f559d3431ded396eb466302789a0aad069e14,
    session_id: 6b4c236254ed285eb1c8ef87b3cc276ec82cbd3c7ac8fea5bba99f6c4b906746,
    cipher_suite: TLS13_AES_128_GCM_SHA256,
    compression_method: Null,
}     current_dir="/Users/djc/src/rustup" args="[\"./target/debug/rustup\", \"update\", \"beta\"]" profile="Default" prefix="/Users/djc/.rustup/toolchains/beta-aarch64-apple-darwin"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants