Skip to content

Set ALPN protocols for rustls backend#4312

Merged
rami3l merged 2 commits intomasterfrom
set-alpn
Apr 26, 2025
Merged

Set ALPN protocols for rustls backend#4312
rami3l merged 2 commits intomasterfrom
set-alpn

Conversation

@djc
Copy link
Copy Markdown
Contributor

@djc djc commented Apr 25, 2025

Fixes #4311.

cc @ctz

@djc djc requested review from ChrisDenton and rami3l April 25, 2025 14:53
@rami3l
Copy link
Copy Markdown
Member

rami3l commented Apr 25, 2025

@djc Would we want @muja to test this new branch again?


Update: Hmmm the CI is failing now, interesting...

@muja
Copy link
Copy Markdown

muja commented Apr 25, 2025

I built & ran this branch, still the same error.

@ctz
Copy link
Copy Markdown
Contributor

ctz commented Apr 25, 2025

I am pretty confident this is not the root cause of #4305

@djc
Copy link
Copy Markdown
Contributor Author

djc commented Apr 25, 2025

Update: Hmmm the CI is failing now, interesting...

We didn't actually enable http2 for our reqwest dependency. Should be better now.

@rami3l rami3l added this pull request to the merge queue Apr 26, 2025
Merged via the queue into master with commit b79969b Apr 26, 2025
29 checks passed
@rami3l rami3l deleted the set-alpn branch April 26, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustup ought to tell rustls an ALPN

4 participants