test(cli-exact): migrate to .expect() APIs#4352
Merged
rami3l merged 1 commit intorust-lang:masterfrom Jun 2, 2025
Merged
Conversation
3 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR updates CLI tests to use the .expect() API and includes the missing MULTI_ARCH1 constant in redaction checks.
- Migrates assertions to
.expect()for stronger validation. - Imports
MULTI_ARCH1and adds its redaction entry insrc/test/clitools.rs.
djc
approved these changes
Jun 2, 2025
rami3l
requested review from
ChrisDenton and
djc
and removed request for
ChrisDenton and
djc
Member
Author
|
Oops, I had a somewhat slow network so the previous requests didn't get through 😓 Never mind... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4359.
SemanticDiff