Skip to content

Curl#436

Closed
brson wants to merge 6 commits intorust-lang:masterfrom
brson:curl
Closed

Curl#436
brson wants to merge 6 commits intorust-lang:masterfrom
brson:curl

Conversation

@brson
Copy link
Copy Markdown
Contributor

@brson brson commented May 11, 2016

Supercedes #434

alexcrichton and others added 2 commits May 10, 2016 17:18
Unfortunately the move to rust-native-tls has had some hiccups on Windows and
Hyper also currently doesn't support features like HTTP proxies (but support's
coming soon!). For now this temporarily moves over to using libcurl to weed out
these problems until we get to a point where we're hyper's features are more
filled out. This also somewhat aligns with Cargo as well which is using libcurl
currently.

This does not use the `curl` crate on crates.io because it doesn't support
streaming downloads. Instead I've got an in-progress rewrite which is just
binding much more directly to libcurl's APIs (e.g. exposing the callback
functions directly). This branch is in a git repo currently and I hope to
upstream it to curl-rust soon as well.
@brson
Copy link
Copy Markdown
Contributor Author

brson commented May 11, 2016

@brson
Copy link
Copy Markdown
Contributor Author

brson commented May 11, 2016

Seems like it can't find 'make'?

@alexcrichton
Copy link
Copy Markdown
Member

Yeah I think that's the fix, although I believe the path is C:\msys64\usr\bin instead of C:\msys64\mingw$BITS\usr\bin

@brson
Copy link
Copy Markdown
Contributor Author

brson commented May 11, 2016

Failing for yet new reasons.

appveyor.yml Outdated
- ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))

install:
- if defined MSYS_BITS set PATH=C:\msys64\mingw%MSYS_BITS%\bin;C:\msys64\usr\bin;%PATH%
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/MSYS_BITS/BITS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants