Merged
Conversation
Contributor
|
Nice! This isn't a criticism, but why did you choose to explicitly call |
Member
Author
|
Ah yeah that'd be possible, I just figured that the layer of a macro indirection probably wasn't worth it. |
Contributor
|
☔ The latest upstream changes (presumably #420) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
lgtm |
This removes the usage of #[fundamental] and intrinsics::type_name in the
notifications module. The `Notifyable` trait and `Notifier` struct were also
removed in favor of just using `&Fn(Notification)` where necessary. This change
is less ergonomic when crossing crate boundaries where `Notifier` naturally
implemented `Notifyable` for multiple notification types before. Instead, now
closures must be written as:
&|n| prev_handler(n.into())
Which is to say that when crossing crate boundaries you need to remap
notification closures and leverage a `From` implementation.
This crate does not currently compile on the stable *channel* due to the usage
of `panic::catch_unwind` in the curl crate for now, but that will get fixed with
the next stable release, this is just paving the way forward!
Closes rust-lang#58
alexcrichton
force-pushed
the
stable-rust
branch
2 times, most recently
from
0c1e32e to
be106e7
Compare
We can't open it for writing as any concurrent forks would keep a writable file descriptor open which would prevent us from then executing the file with a "text file busy" error. On windows we keep copying as this problem isn't present and symlinks don't work that well on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the usage of #[fundamental] and intrinsics::type_name in the
notifications module. The
Notifyabletrait andNotifierstruct were alsoremoved in favor of just using
&Fn(Notification)where necessary. This changeis less ergonomic when crossing crate boundaries where
Notifiernaturallyimplemented
Notifyablefor multiple notification types before. Instead, nowclosures must be written as:
Which is to say that when crossing crate boundaries you need to remap
notification closures and leverage a
Fromimplementation.This crate does not currently compile on the stable channel due to the usage
of
panic::catch_unwindin the curl crate for now, but that will get fixed withthe next stable release, this is just paving the way forward!
Closes #58