Skip to content

Adding TOOLCHAIN_HELP to rustup help install#496

Merged
brson merged 2 commits intorust-lang:masterfrom
peschkaj:add-toolchain-help-to-install
Jun 7, 2016
Merged

Adding TOOLCHAIN_HELP to rustup help install#496
brson merged 2 commits intorust-lang:masterfrom
peschkaj:add-toolchain-help-to-install

Conversation

@peschkaj
Copy link
Copy Markdown
Contributor

Adds the help from TOOLCHAIN_HELP to rustup help install. There are likely other places we can add this and get additional help about <toolchain> into rustup.

This should fix #483

@peschkaj
Copy link
Copy Markdown
Contributor Author

peschkaj commented Jun 2, 2016

@brson Does this work for you?

@brson
Copy link
Copy Markdown
Contributor

brson commented Jun 3, 2016

OK, sorry for the delay.

I'd prefer to see the help for update and install be similar, with an INSTALL_HELP text that is substantially similar to UPDATE_HELP. If <toolchain> isn't sufficiently explained then it needs to be explained in both places.

Instead of explaining in full what a toolchain is perhaps these two could contain more abbreviated text with pointers to more information:

'toolchain' specifies a toolchain name, such as 'stable', 'nightly', or '1.8.0'. For more information see rustup help toolchain.

@peschkaj
Copy link
Copy Markdown
Contributor Author

peschkaj commented Jun 3, 2016

👍 will revise.

Thanks for the eyeballs.

@brson brson merged commit 3bae543 into rust-lang:master Jun 7, 2016
@brson
Copy link
Copy Markdown
Contributor

brson commented Jun 7, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustup help install doesn't say what <toolchain> is

2 participants