Skip to content

Remove unavailable toolchains from target list#553

Merged
brson merged 4 commits intorust-lang:masterfrom
leroycep:master
Jul 6, 2016
Merged

Remove unavailable toolchains from target list#553
brson merged 4 commits intorust-lang:masterfrom
leroycep:master

Conversation

@leroycep
Copy link
Copy Markdown
Contributor

This should close issue #299

leroycep added 2 commits June 28, 2016 23:00
I am not sure if it works because I can't get it to build on my Windows 10 machine
component: component.clone(),
required: true,
installed: installed,
available: targ_pkg.available,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost there, but not quite. The TargettedPackage represented by targ_pkg is the "rust" package, but you need the TargettedPackage for each of the components of "rust" (the "rust" package is made up of other components like "rust-std", each with their own packages).

So in both these loops over components you're going to need to take the pkg and target fields of the component and then look up the targetted package in the manifest for that component. This is done the same way as the lookups for the previous rust_pkg and targ_pkg variables.

Thanks!

@leroycep
Copy link
Copy Markdown
Contributor Author

leroycep commented Jul 4, 2016

Thanks for the advice! I think I fixed it now, but I'm not sure.

Also, as a side note, how do I run rustup instead of the installer? I haven't been able to find that information anywhere.

@brson brson merged commit c0be63e into rust-lang:master Jul 6, 2016
@brson
Copy link
Copy Markdown
Contributor

brson commented Jul 6, 2016

Thanks @Geemili!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants