Skip to content

Fallback to old download methods if server returns 403#573

Merged
alexcrichton merged 1 commit intorust-lang:masterfrom
brson:fallback
Jul 12, 2016
Merged

Fallback to old download methods if server returns 403#573
alexcrichton merged 1 commit intorust-lang:masterfrom
brson:fallback

Conversation

@brson
Copy link
Copy Markdown
Contributor

@brson brson commented Jul 12, 2016

Fixes #452

Can't be tested because no network tests.

r? @alexcrichton

@est31
Copy link
Copy Markdown
Member

est31 commented Jul 12, 2016

Nice to see a fix being proposed so fast :)

@alexcrichton alexcrichton merged commit e6b867b into rust-lang:master Jul 12, 2016
@jethrogb
Copy link
Copy Markdown
Contributor

Why don't you just test for all 400 codes?

@brson
Copy link
Copy Markdown
Contributor Author

brson commented Jul 13, 2016

@jethrogb That sounds good to me if you want to submit a patch.

@est31
Copy link
Copy Markdown
Member

est31 commented Jul 13, 2016

Can there be a new release?

@masklinn
Copy link
Copy Markdown

@brson since server changes have already failed rustup.sh several time, wouldn't it be possible and simpler to generate the relevant manifests for older releases (at least the "release" channels anyway) and avoid the fallback?

@brson
Copy link
Copy Markdown
Contributor Author

brson commented Jul 14, 2016

@est31 I'm working on getting a new release out.

@masklinn That approach is possible, yes. It hasn't seemed worth it since this is also simple and the code already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants