Allow any toolchain to be specified as the default during rustup installation.#586
Merged
brson merged 1 commit intorust-lang:masterfrom Jul 19, 2016
jimmycuadra:custom-default-toolchain
Merged
Allow any toolchain to be specified as the default during rustup installation.#586brson merged 1 commit intorust-lang:masterfrom jimmycuadra:custom-default-toolchain
brson merged 1 commit intorust-lang:masterfrom
jimmycuadra:custom-default-toolchain
Conversation
| expect_stdout_ok(config, &["rustup", "show"], "2015-01-02"); | ||
| }); | ||
| } | ||
|
|
Contributor
|
Thanks for this! |
|
Got here from #559 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of restricting the
--default-toolchainargument torustup-initto one of the release channel names, allow any toolchain specification, but warn the user if they do so, since this makes it easier to accidentally install rustup with an invalid toolchain name.Fixes #559.