Skip to content

making rustup prepend cargo bin to path instead of append#707

Merged
brson merged 2 commits intorust-lang:masterfrom
ducks:prepend-cargo-bin-to-path
Sep 3, 2016
Merged

making rustup prepend cargo bin to path instead of append#707
brson merged 2 commits intorust-lang:masterfrom
ducks:prepend-cargo-bin-to-path

Conversation

@ducks
Copy link
Copy Markdown

@ducks ducks commented Sep 1, 2016

A first attempt at fixing #475

I'm not sure if the change is this simple because I'm honestly not sure how to test this one.
But I changed the Toolchain::set_ldpath to prepend instead of append.

If you could share some advice on how to test I'm more than willing to do so :)

@ducks
Copy link
Copy Markdown
Author

ducks commented Sep 1, 2016

Looking at the CI build I would say it's not that simple

So it seems like I need to make that use a std::path::Path instead of a vec<PathBuf>

I try building this locally but don't seem to get the same issue.
(oh, some of the tests seem to be passing now. maybe that's why. yay.)

@brson
Copy link
Copy Markdown
Contributor

brson commented Sep 3, 2016

Looks good. Thanks @rjgoldsborough !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants