Merged
Conversation
Temporary hack to avoid issues with consistent checksumming on the CDN. Issue rust-lang#524
Contributor
Author
|
I was pretty sleepy when I implemented this. Please read it closely. |
Member
|
Looks good to me! It's intentional right that the sha256 file isn't downloaded and checked though, right? Other than that after the compile error is fixed r=me |
This changes the update process in the following ways: the current version is read from the server at /rustup/stable-release.toml; if the version is different from the running version then rustup downloads the new release from the archives at /rustup/archive/$version/. Fixes rust-lang#524
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix checksum failures with new self-update process
This changes the update process in the following ways: the current
version is read from the server at /rustup/stable-release.toml; if the
version is different from the running version then rustup downloads
the new release from the archives at /rustup/archive/$version/.
Fixes #524
This is intended to be a temporary solution until the full solution detailed here is implemented.
r? @alexcrichton