Only include dependencies when binary feature is enabled#68
Merged
Conversation
This change vastly improves compile times when only `lib.rs` is compiled. However, it is a breaking change.
This results in a much better error message when a build without that feature is attempted.
Member
Author
|
To try this change today:
Now building the bootloader library should no longer require compiling the bootloader dependencies: |
Contributor
|
Actually there is one more thing - do we need the build script when the binary feature is disabled? We are still pulling in |
Member
Author
|
Good point! I disabled the build script and the llvm-tools dependency too now |
Member
Author
|
I think it's fine to merge this now. We will need to release a new semver-breaking version anyway, so no breakage should occur unless you manually increase the bootloader version in your Cargo.toml. |
Member
Author
|
Published as version 0.7.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change vastly improves compile times when only
lib.rsis compiled because no dependencies need to be compiled in this case. See rust-lang/cargo#1982 (comment) for more information about the approach.This is a breaking change since a build of the executable without the
binaryfeature will result in an error.Depends on rust-osdev/bootimage#43, so we will need to increase the minimally supported bootimage version. To avoid public breakage, we should probably wait a bit after releasing the new bootimage version to give people time to upgrade.