Dynamically map kernel stack, boot info, physical memory and recursive table#71
Merged
bors[bot] merged 2 commits intorust-osdev:masterfrom Aug 1, 2019
Merged
Dynamically map kernel stack, boot info, physical memory and recursive table#71bors[bot] merged 2 commits intorust-osdev:masterfrom
bors[bot] merged 2 commits intorust-osdev:masterfrom
Conversation
phil-opp
reviewed
Aug 1, 2019
Member
phil-opp
left a comment
phil-opp
left a comment
There was a problem hiding this comment.
Thanks a lot for tackling this! I think I found a small bug (exclusive instead of inclusive range), otherwise the changes look very good to me.
phil-opp
approved these changes
Aug 1, 2019
Member
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 1, 2019
71: Dynamically map kernel stack, boot info, physical memory and recursive table r=phil-opp a=64 Fixes #61. This provides a way for the user to set the kernel stack address through an environment variable, or calculate it dynamically, making sure that it does not interfere with any other mappings. We also calculate space for the recursive page table, boot info and physical memory offset, with the small optimisation that the boot info and kernel stack are placed adjacently if possible to save a few extra page table allocations. Going to punt on a way to unmap these things for now. Reclaiming memory from unused page tables is a bit tricky and it would be nice to do it right. Co-authored-by: Matt Taylor <mstaveleytaylor@gmail.com>
Contributor
Build succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61. This provides a way for the user to set the kernel stack address through an environment variable, or calculate it dynamically, making sure that it does not interfere with any other mappings. We also calculate space for the recursive page table, boot info and physical memory offset, with the small optimisation that the boot info and kernel stack are placed adjacently if possible to save a few extra page table allocations.
Going to punt on a way to unmap these things for now. Reclaiming memory from unused page tables is a bit tricky and it would be nice to do it right.