Change the way the kernel entry point is called to honor alignement ABI#81
Merged
phil-opp merged 1 commit intorust-osdev:masterfrom Oct 8, 2019
Merged
Conversation
Compilers expect functions to be called with the stack containing the return address making the rsp be 8 mod 16. jmp caused rsp to be 0 mod 16 (aka 16 bytes aligned), which then caused compiler to meke the stack misaligned everywhere.
Contributor
Author
|
Apparently the test just blew up because rustfmt is unavailable in todays nightly 😱 |
Contributor
Author
|
Note all the test passed apart from the missing rustfmt. |
Member
|
@GuillaumeDIDIER Thanks for reporting and directly fixing this issue! Don't worry about the failing rustfmt checks. This is a known problem and I already have a solution in mind. I'm planning to rewrite the CI scripts and update the testing framework soon, and I will fix it then. |
Member
|
Published as version 0.8.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilers expect functions to be called with the stack containing the return address making the rsp be 8 mod 16. jmp caused rsp to be 0 mod 16 (aka 16 bytes aligned), which then caused compiler to meke the stack misaligned everywhere.
Fix #80