remove unnecessary extern C on panic handler to fix not-ffi-safe warning#85
Merged
phil-opp merged 1 commit intorust-osdev:masterfrom Nov 20, 2019
Merged
remove unnecessary extern C on panic handler to fix not-ffi-safe warning#85phil-opp merged 1 commit intorust-osdev:masterfrom
phil-opp merged 1 commit intorust-osdev:masterfrom
Conversation
Member
|
Thanks a lot for the pull request! There seems to be a small problem with the "Check Formatting" CI job, but this has nothing to do with your changes. I will fix it and merge this PR afterwards. |
Member
|
CI should be fixed now. bors r+ |
phil-opp
approved these changes
Nov 18, 2019
Member
|
There seems to be a problem with the bors bot: bors-ng/bors-ng#806 Merging manually |
phil-opp
added a commit
that referenced
this pull request
Nov 20, 2019
Member
|
Released as version 0.8.3. Thanks again for the pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.40.0-nightly has added a warning about extern functions that are not ffi-safe.
the panic handler is unnecessarily marked as extern and trips this warning.
this pull request removes the extern decleration to fix the warning.
Fixes #84