Skip to content

Move register types to x86_64_types crate#73

Closed
npmccallum wants to merge 1 commit intorust-osdev:masterfrom
npmccallum:master
Closed

Move register types to x86_64_types crate#73
npmccallum wants to merge 1 commit intorust-osdev:masterfrom
npmccallum:master

Conversation

@npmccallum
Copy link
Copy Markdown
Member

No description provided.

@npmccallum
Copy link
Copy Markdown
Member Author

@phil-opp FYI

@phil-opp
Copy link
Copy Markdown
Member

phil-opp commented May 4, 2019

Looks good to me in general. I don't think that we want to merge this into master directly, because git dependencies are not allowed on crates.io. I just created a dev branch, could you create a new pull request against that branch? This way, we can experiment with the split while keeping the master branch publishable.

@phil-opp phil-opp mentioned this pull request Jun 3, 2019
@npmccallum
Copy link
Copy Markdown
Member Author

@phil-opp Would it be better to just release a version of x86_64_types?

@phil-opp
Copy link
Copy Markdown
Member

phil-opp commented Jun 3, 2019

@npmccallum Yes, we could do that too. I just want to avoid repeated breaking changes of x86_64, so perhaps it's better to keep it in a separate branch to allow more experimentation on the type APIs?

@phil-opp
Copy link
Copy Markdown
Member

Closing as stale. I'm happy to continue experimentation on this matter if you like @npmccallum.

@phil-opp phil-opp closed this Apr 10, 2020
@npmccallum
Copy link
Copy Markdown
Member Author

@haraldh and @connorkuehl are mostly doing this work now.

@phil-opp
Copy link
Copy Markdown
Member

Thanks for the update!

@phil-opp
Copy link
Copy Markdown
Member

Hi @haraldh, @connorkuehl, @npmccallum

Is this still something that is planned? Otherwise I think we can remove the https://github.com/rust-osdev/x86_64_types repo and delete the empty https://crates.io/crates/x86_64_types placeholder crate.

@haraldh
Copy link
Copy Markdown
Contributor

haraldh commented Dec 20, 2025

Oh.. I don't even remember the rationale of pulling out these types.. yeah, sadly most of us don't do low level x86 development with rust anymore. Please go ahead and do as you like. Thank you for the hard work!!!

@phil-opp
Copy link
Copy Markdown
Member

Thanks for the quick reply! I'll archive the repo and delete the crate then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants