Skip to content

Backport update to cfg-if v1.0 to the v0.1 branch#173

Merged
josephlr merged 1 commit into0.1from
newpavlov-patch-1
Dec 31, 2020
Merged

Backport update to cfg-if v1.0 to the v0.1 branch#173
josephlr merged 1 commit into0.1from
newpavlov-patch-1

Conversation

@newpavlov
Copy link
Copy Markdown
Member

Requested in #166.

@Dragonrun1
Copy link
Copy Markdown

So this is now the only part of rand crates that is still using the old version of cfg-if. Do we have a timeline when this is getting merged?

@newpavlov
Copy link
Copy Markdown
Member Author

newpavlov commented Dec 31, 2020

@Dragonrun1
It's blocked on @josephlr approving this PR. Also note that rand v0.8 uses getrandom v0.2 which does not use the old version of cfg-if.

@Dragonrun1
Copy link
Copy Markdown

Dragonrun1 commented Dec 31, 2020

Actually I just updated to rand 0.8 and was looking with cargo tree and noticed it showing this package still using the old version. If you look at the Cargo.toml on getrandom it still shows cfg-if = "0.1.2" so that kind of why I decided to ask 😉

Edit Just looked and the main branch has been updated to cfg-if = "1" but that's not been push up to crates.io yet.

Copy link
Copy Markdown
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for letting this slip by. Thanks for the backport!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants