Always build on wasm32-unknown-unknown#90
Merged
josephlr merged 4 commits intorust-random:masterfrom Aug 17, 2019
Merged
Conversation
This updates the documentation to explain exacly what we are doing on this target. Also adds a test that the target builds without features.
dhardy
approved these changes
Aug 17, 2019
Member
dhardy
left a comment
dhardy
left a comment
There was a problem hiding this comment.
Looks like a good solution to me; just one typo here.
Member
|
Personally I am not happy about this exception... But I guess we will have to add it for the time being. I will merge it and release v0.10 after the typo fix. |
takumi-earth
pushed a commit
to earthlings-dev/getrandom
that referenced
this pull request
Jan 27, 2026
This updates the documentation to explain exactly what we are doing on this target. Also adds a test that the target builds without features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the documentation to explain exacly what we are doing on
this target. Also adds a test that the target builds without features.
Address issues in #87 and makes #89 unnecessary.
CC: @Lokathor