build(deps): update vm-memory requirement from 0.12.2 to 0.13.0#162
build(deps): update vm-memory requirement from 0.12.2 to 0.13.0#162
Conversation
b67217a to
098da65
Compare
316569a to
098da65
Compare
|
This is blocked on rust-vmm/vm-memory#256 |
b5aa9ba to
b21357f
Compare
|
@roypat for bisectability would it be better to merge the first 2 commits together? |
Mh, I think usually we try to keep the dependabot-created commits untouched, and add the fixes in additional commits onto the dependabot branch. |
Okay, sorry I'm not codeowner of this crate, so I didn't know about this policy. I personally prefer to try to have every commit buildable, but it’s up to you ;-) |
I don't think that sounds like a very good idea from a bisectability perspective. I don't think the dependabot's feelings will be hurt if you take it's commit and |
b21357f to
3a13d47
Compare
Alright, if we don't care about preserving the dependabot commits then I don't see any problems either :) I've squashed the first two commits. |
Updates the requirements on [vm-memory](https://github.com/rust-vmm/vm-memory) to permit the latest version. - [Release notes](https://github.com/rust-vmm/vm-memory/releases) - [Changelog](https://github.com/rust-vmm/vm-memory/blob/main/CHANGELOG.md) - [Commits](rust-vmm/vm-memory@v0.12.2...v0.13.0) --- updated-dependencies: - dependency-name: vm-memory dependency-type: direct:production ... In addition to the dependabot changes, this commit updates usages of deprecated functions. With vm-memory 0.13.0, we introduced versions of the Read and Write traits for operations on guest memory (`VolatileRead` and `VolatileWrite`). These replace various `Read` and `Write` based APIs that had suboptional performance due to requiring to first copy all data from guest memory to hypervisor memory to ensure soundness. See also rust-vmm/vm-memory#217. Signed-off-by: Patrick Roy <roypat@amazon.co.uk> Co-authored-by: dependabot[bot] <support@github.com>
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
3a13d47 to
e86ba8a
Compare
|
+1 on squashing dependabot's commits. You can mention it was originally an automatic dependabot PR in the commit description if you like. |
Ah, my mistake - I didn't realise it was "just a warning". I can see the merits of both ways when it comes to a warning but for build errors I do think it's better for the tree to be bisectable. |
Updates the requirements on vm-memory to permit the latest version.
Changelog
Sourced from vm-memory's changelog.
... (truncated)
Commits
a6bcb43chore: Prepare release 0.13.051a6c74Add CHANGELOG entry about ReadVolatile/WriteVolatile20135ceAdjust coverage7a911a4Add read_volatile_from/write_volatile_to to GuestMemory9c3e6aatest: Add tests for VolatileRead/Write0173112feat: Introduce Read/WriteVolatile traitsYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)