Add systemd support#14
Conversation
andy-s-clark
commented
Aug 1, 2016
- Add support for systemd on RHEL 7 / CentOS 7
- Move creation of pid, socket and log directories out of the startup scripts and into puppet.
|
|
||
| [Service] | ||
| Type=simple | ||
| ExecStart=/usr/sbin/uwsgi --die-on-term --ini <%= @config_file %> |
There was a problem hiding this comment.
Should you parameterise the uwsgi binary location or just leave the path off? I'm just imagining other distros that use systemd may not install uwsgi into sbin.
There was a problem hiding this comment.
I'll parameterize the binary path. On CentOS 7, the service failed to start without the full path.
Any preference for the name of the parameter? "app_binary_directory"?
There was a problem hiding this comment.
I'd just go with something like "binary_location" and include the uwsgi component. Thoughts?
There was a problem hiding this comment.
I used the name "binary_directory" in order to match the variables "app_directory", "log_directory", etc.
There was a problem hiding this comment.
Right, that makes sense. Fine with me.
|
Could you please modify the README |
* Add binary_directory parameter for systemd * Add systemd information to README
|
@andy-s-clark I'm unsure if I'm going to release this or not. It depends on the outcome of cwood#7 My module isn't very well maintained and includes no tests, so if the fork is willing to take over, then I'd be happy for that to happen. I'd then ask you to target your patch at the fork. |