Merged
Conversation
several python3 related fixes: ctype char * now requries bytes (was string) some calculations now seem to need int()
Owner
Author
|
I don't quite understand why the calculations need int(), as I don't think that's my code and I'm fairly sure it worked on Python 3 before... However I can't see that int() will do any harm, so may as well leave it in there. |
|
I don't know why either but it complained that indices must be integers and that (float & int) is not a valid expression without them. |
Owner
Author
|
Fair enough! I wonder if perhaps the cause of the error is elsewhere, perhaps I've done a / rather than a // somewhere else in the code I added, and I didn't notice because I only tested in Python 2. If I get time I might test the upstream picamera module and see if it has the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
several python3 related fixes:
ctype char * now requries bytes (was string)
some calculations now seem to need int()