Skip to content

Commit c4859f4

Browse files
authored
Fix Coverage in CI (#945)
Coveralls parallel builds need some additional configuration, it looks like it was sporadically failing in CI, and I think it was misconfigured: - We want the flag name to be the contract name from the coverage matrix - We want finishing to depend on the `coverage` step and not the testing step Changes were done based on the documentation here: https://docs.coveralls.io/parallel-builds
1 parent c73f36c commit c4859f4

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,12 @@ jobs:
7474
uses: coverallsapp/github-action@v2
7575
with:
7676
parallel: true
77-
flag-name: run-$
77+
flag-name: run-${{ matrix.contract-name }}
7878
github-token: ${{ secrets.GITHUB_TOKEN }}
7979

8080
finish:
8181
runs-on: ubuntu-latest
82-
needs: tests
82+
needs: coverage
8383
if: ${{ always() }}
8484
steps:
8585
- name: Coveralls Finished

0 commit comments

Comments
 (0)