Skip to content

Fix Coverage in CI#945

Merged
remedcu merged 1 commit intomainfrom
fix/ci-coverage
Apr 11, 2025
Merged

Fix Coverage in CI#945
remedcu merged 1 commit intomainfrom
fix/ci-coverage

Conversation

@nlordell
Copy link
Copy Markdown
Collaborator

@nlordell nlordell commented Apr 10, 2025

Coveralls parallel builds need some additional configuration, it looks like it was sporadically failing in CI, and I think it was misconfigured:

  • We want the flag name to be the contract name from the coverage matrix
  • We want finishing to depend on the coverage step and not the testing step

Changes were done based on the documentation here: https://docs.coveralls.io/parallel-builds

Coveralls parallel builds need some additional configuration, it looks
like it was sporadically failing in CI, and I think it was
misconfigured:
- We want the flag name to be the contract name from the coverage
  matrix
- We want finishing to depend on the `coverage` step and not the
  testing step
@nlordell nlordell requested a review from a team as a code owner April 10, 2025 14:23
@nlordell nlordell requested review from akshay-ap, mmv08, remedcu and rmeissner and removed request for a team April 10, 2025 14:23
@remedcu remedcu merged commit c4859f4 into main Apr 11, 2025
33 checks passed
@remedcu remedcu deleted the fix/ci-coverage branch April 11, 2025 08:08
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants