(potential) Encoding Issue with create_product_review_and_seller_feedback_solicitation

[marek715]

Describe the bug
JSONDecodeError when using create_product_review_and_seller_feedback_solicitation

File "C:\Users\user\anaconda3\envs\py36\lib\site-packages\sp_api\base\helpers.py", line 21, in wrapper return function(*args, **kwargs) File "C:\Users\user\anaconda3\envs\py36\lib\site-packages\sp_api\api\solicitations\solicitations.py", line 70, in create_product_review_and_seller_feedback_solicitation return self._request(fill_query_params(kwargs.pop('path'), amazonOrderId), params=kwargs) File "C:\Users\user\anaconda3\envs\py36\lib\site-packages\sp_api\base\client.py", line 105, in _request return self._check_response(res) File "C:\Users\user\anaconda3\envs\py36\lib\site-packages\sp_api\base\client.py", line 109, in _check_response error = res.json().get('errors', None) File "C:\Users\user\anaconda3\envs\py36\lib\site-packages\requests\models.py", line 900, in json return complexjson.loads(self.text, **kwargs) File "C:\Users\user\anaconda3\envs\py36\lib\json\__init__.py", line 348, in loads return _default_decoder.decode(s) File "C:\Users\user\anaconda3\envs\py36\lib\json\decoder.py", line 337, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "C:\Users\user\anaconda3\envs\py36\lib\json\decoder.py", line 355, in raw_decode raise JSONDecodeError("Expecting value", s, err.value) from None json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

To Reproduce

Cannot reproduce as it seems to send the solicitation correctly and I do not get the error on subsequent runs as a result.

I am sending it with this command:
res = Solicitations(credentials=credentials).create_product_review_and_seller_feedback_solicitation(oid,marketplaceIds=market_id)

Expected behavior

Not sure how to capture the JSON if I get an error in this place, but I expected the JSON in the APIResponse to decode without issues.

Desktop (please complete the following information):

Windows using Anaconda env with py3.6

Additional context

Seems like a similar error to this one:
#178

[saleweaver]

I've never used this Api endpoint, did you solve it yet, or do you still need help?

[marek715]

I've never used this Api endpoint, did you solve it yet, or do you still need help?

Hello! Your answer here got me some interesting results:
#243

TLDR: I was not able to reproduce it locally yet using pdb. This fact seems to indicate I have something wrong with my dev environment setup or perhaps Amazon changed what it sends after the point in time I set the code up locally with the debugger.

The next steps are:

1. Reproduce it in my original program again to ensure Amazon didn't fix something on their side
2. If I see it again, I will have to try to fix the exception error and try to capture the special character again.

Full Details:
In trying to reproduce the error, my first run after adding the debugger resulted in an error here on the very first order (this happens before the point where there is a possibility for a decode error):
https://github.com/saleweaver/python-amazon-sp-api/blob/master/sp_api/base/client.py#L112

So I commented the following line out and replaced it with a print:
raise exception(error)

That is unrelated to the decode issue, but after commenting that out I did not see the decode errors for the next 200-300 requests via the solicitation endpoint. I don't think commenting out this line should fix a decode issue. I ran into the problem using python-amazon-sp-api==0.6.4, which seems to be the latest version (unless what I downloaded via git from master is different).

Something interesting I learned from the debugger is that every successful result of using this endpoint (generating a solicitation request), gets a response from Amazon of an empty dictionary. So {} is success in every case I am seeing now and currently no decode errors. Perhaps the decode error occurs when they send a special char in the dictionary by mistake?

I will continue testing and will get back to you on what I find.