Skip to content

Remove experimental parallel feature#1013

Merged
Veykril merged 1 commit into
salsa-rs:masterfrom
MichaReiser:remove-parallel
Oct 22, 2025
Merged

Remove experimental parallel feature#1013
Veykril merged 1 commit into
salsa-rs:masterfrom
MichaReiser:remove-parallel

Conversation

@MichaReiser

@MichaReiser MichaReiser commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Remove the experimental parallel feature.

We still want something like this in the future, but the tests are flaky (Miri now gets stuck consistently)
and neither ty or r-a are using the feature (and there's no other maintainer driving the feature forward).

The feature is also surprising, because you aren't supposed to use it within a query because
The outer query won't track the dependencies of the queries running in parallel (which raises questions about how this would work with maybe_changed_after).

Parallel execution with Salsa is possible even without this feature. You can clone your db (add a dyn_clone method to your Db trait if you only have a &dyn Db)
and pass a separate instance to each thread.

Closes #994

@netlify

netlify Bot commented Oct 22, 2025

Copy link
Copy Markdown

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit b0787c2
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/68f8c0d54f7157000833a883

@MichaReiser

Copy link
Copy Markdown
Contributor Author

We still need the rayon feature for the salsa::Update implementation for rayon::Either

@codspeed-hq

codspeed-hq Bot commented Oct 22, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1013 will improve performances by 4.37%

Comparing MichaReiser:remove-parallel (b0787c2) with master (a4113cd)

Summary

⚡ 1 improvement
✅ 12 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
amortized[SupertypeInput] 2.8 µs 2.7 µs +4.37%

@Veykril Veykril enabled auto-merge October 22, 2025 11:41
@Veykril Veykril added this pull request to the merge queue Oct 22, 2025
Merged via the queue into salsa-rs:master with commit ffa811d Oct 22, 2025
12 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: flaky hangs and failures in parallel_*::execute_cancellation tests

2 participants