Skip to content

Add DidFinalizeCycle event, add more tests for cyclic nested queries#1052

Merged
MichaReiser merged 3 commits into
salsa-rs:masterfrom
MichaReiser:micha/no-early-converge
Jan 7, 2026
Merged

Add DidFinalizeCycle event, add more tests for cyclic nested queries#1052
MichaReiser merged 3 commits into
salsa-rs:masterfrom
MichaReiser:micha/no-early-converge

Conversation

@MichaReiser

@MichaReiser MichaReiser commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

This adds a new DidFinalizeCycle event that Salsa emits when the outermost cycle head is finalized.

This PR also adds two new tests:

  1. A test where the nested cycle converges before the outer cycle converges (it can be finalized before the outer cycle
  2. A test where the nested cycle never converges, but the outer cycle only depends on it in the first iterations.

I haven't yet decided on what the expectation is for both those cases, but I thought it's worth adding tests

@MichaReiser MichaReiser changed the title Add DidFinalizeCycle event, add more tests for cyclic nested queries" Add DidFinalizeCycle event, add more tests for cyclic nested queries Jan 5, 2026
@netlify

netlify Bot commented Jan 5, 2026

Copy link
Copy Markdown

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit a40ea13
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/695e2a830f86c20008f83fa4

@codspeed-hq

codspeed-hq Bot commented Jan 5, 2026

Copy link
Copy Markdown

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing MichaReiser:micha/no-early-converge (a40ea13) with master (103fa51)

Summary

✅ 13 untouched benchmarks

@MichaReiser MichaReiser requested review from carljm and ibraheemdev and removed request for carljm January 5, 2026 15:28
Comment thread src/event.rs Outdated
Comment thread src/event.rs Outdated
Co-authored-by: Ibraheem Ahmed <ibraheem@ibraheem.ca>
@MichaReiser MichaReiser enabled auto-merge January 7, 2026 09:43
@MichaReiser MichaReiser added this pull request to the merge queue Jan 7, 2026
Merged via the queue into salsa-rs:master with commit ad546bb Jan 7, 2026
12 checks passed
@MichaReiser MichaReiser deleted the micha/no-early-converge branch January 7, 2026 10:00
@github-actions github-actions Bot mentioned this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants