Add DidFinalizeCycle event, add more tests for cyclic nested queries#1052
Merged
Merged
Conversation
DidFinalizeCycle event, add more tests for cyclic nested queries"DidFinalizeCycle event, add more tests for cyclic nested queries
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
ibraheemdev
approved these changes
Jan 7, 2026
Co-authored-by: Ibraheem Ahmed <ibraheem@ibraheem.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
DidFinalizeCycleevent that Salsa emits when the outermost cycle head is finalized.This PR also adds two new tests:
I haven't yet decided on what the expectation is for both those cases, but I thought it's worth adding tests