Fix tracked impl db lifetime for as_deref return mode#1084
Merged
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
MichaReiser
approved these changes
Apr 24, 2026
Contributor
|
Took me a while to understand what this PR is about, but what I understand is that it sets the right lifetime for: - <AsDerefInput as InnerTrait_>::as_deref_method_(this, db)
+ <AsDerefInput as InnerTrait_<'db>>::as_deref_method_(this, db) |
Veykril
force-pushed
the
push-mrtsmuusvuyk
branch
from
236e527 to
b3dbff7
Compare
Member
Author
|
Right, sorry for the lack of commit message this was a drive by while being busy. But yea, basically the macro needs to emit lifetimes explicitly when invoked in associated item position due to elision rules |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.