perf: Don't store the fields in the interned map#812
Merged
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #812 will not alter performanceComparing Summary
|
Contributor
Author
|
Wow, zero regressions! Good to go I guess? |
Veykril
reviewed
Apr 22, 2025
Instead, store only an `Id`, to save memory.
ChayimFriedman2
force-pushed
the
interned-map-mem
branch
from
ec23b64 to
f4ee327
Compare
Veykril
approved these changes
Apr 22, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, store only an
Id, to save memory.This saves 65mb on rust-analyzer. Wants to see the speed impact.