Add a generic variant for the NRF52840DK board#533
Open
needs-coffee wants to merge 1 commit intosandeepmistry:masterfrom
Open
Add a generic variant for the NRF52840DK board#533needs-coffee wants to merge 1 commit intosandeepmistry:masterfrom
needs-coffee wants to merge 1 commit intosandeepmistry:masterfrom
Conversation
|
Hi, First of all, thank you for the hard work of making a PR to add support for this board. I'm a newbie at making BSPs but, shouldn't we be adding something to boards.txt as well? I've had a look at how it looks in the Adafruit BSP for this board but it seems the chosen programmer is entirely different from the nRF52 DK so I'm at a loss. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a generic variant for the NRF52840DK board that accesses all pins using the NRF GPIO index.
Has the on board peripherals mapped to the correct pin functions.