Add flush() to Print for backwards compatibility#541
Open
bhatasaka wants to merge 1 commit intosandeepmistry:masterfrom
Open
Add flush() to Print for backwards compatibility#541bhatasaka wants to merge 1 commit intosandeepmistry:masterfrom
bhatasaka wants to merge 1 commit intosandeepmistry:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
virtual void flush()declaration to Print.The
void flush()function is referenced in at least one library that I know of - SD Fat, and if this core is used with the library, compilation fails since it tries to overrideflush().This change has already been made to the Adafruit Arduino core: Commit 33d98c0
And a need for this fix mentioned in several other places:
Thank you.