Skip to content

sap_hdbsql: Add new parameter named properties#79

Merged
marcelmamula merged 1 commit into
sap-linuxlab:devfrom
rbn-st:feat/properties-param
Mar 11, 2026
Merged

sap_hdbsql: Add new parameter named properties#79
marcelmamula merged 1 commit into
sap-linuxlab:devfrom
rbn-st:feat/properties-param

Conversation

@rbn-st

@rbn-st rbn-st commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Adds a new module option properties to pass key=value pairs to hdbsql via -Z.

Changes

  • Added properties parameter to sap_hdbsql module
  • Added corresponding unit test
  • Added example in EXAMPLES block

@marcelmamula marcelmamula left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arctix625 Thank you for your contribution.

This change "looks" to be working, but it is difficult to properly test because it seems that hdbsql does not reject wrong inputs.
Even TEST=VALUE is accepted and module is successful returning data.

I am raised new issue in meantime to handle sanitization of parameters so this is fine to have properties same as we have other parameters.

Comment thread plugins/modules/sap_hdbsql.py
@rbn-st rbn-st force-pushed the feat/properties-param branch from 2c69fd6 to 3b12b16 Compare March 11, 2026 14:22
@marcelmamula

Copy link
Copy Markdown
Contributor

@arctix625 Why are you force pushing commits to appear to have just one commit in this PR?

@rbn-st

rbn-st commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

@arctix625 Why are you force pushing commits to appear to have just one commit in this PR?

Sorry, I don't often work with git :(

@marcelmamula

Copy link
Copy Markdown
Contributor

@arctix625 That is fine for now and I will accept it in current state.
For future reference, you should just create new commit when you are applying proposed changes or fixes coming from workflow failures.

Force push should be reserved only to rare situations when your last commit was not good and you want to replace it, not to replace all commits as one. Imagine deleting some code, then finding out it should be there, or forgetting to remove debug code.

@marcelmamula marcelmamula left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelmamula marcelmamula changed the title feat: add module option properties sap_hdbsql: Add new parameter named properties Mar 11, 2026
@marcelmamula marcelmamula merged commit 3bad25a into sap-linuxlab:dev Mar 11, 2026
52 of 56 checks passed
@rbn-st rbn-st deleted the feat/properties-param branch March 11, 2026 15:01
@rbn-st rbn-st restored the feat/properties-param branch March 11, 2026 15:01
@rbn-st rbn-st deleted the feat/properties-param branch March 11, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants