sap_hdbsql: Add new parameter named properties#79
Conversation
727e5ee to
2c69fd6
Compare
marcelmamula
left a comment
There was a problem hiding this comment.
@arctix625 Thank you for your contribution.
This change "looks" to be working, but it is difficult to properly test because it seems that hdbsql does not reject wrong inputs.
Even TEST=VALUE is accepted and module is successful returning data.
I am raised new issue in meantime to handle sanitization of parameters so this is fine to have properties same as we have other parameters.
2c69fd6 to
3b12b16
Compare
|
@arctix625 Why are you force pushing commits to appear to have just one commit in this PR? |
Sorry, I don't often work with git :( |
|
@arctix625 That is fine for now and I will accept it in current state. Force push should be reserved only to rare situations when your last commit was not good and you want to replace it, not to replace all commits as one. Imagine deleting some code, then finding out it should be there, or forgetting to remove debug code. |
Adds a new module option
propertiesto pass key=value pairs to hdbsql via-Z.Changes
propertiesparameter tosap_hdbsqlmodule