Allow _ as a type lambda placeholder in -Ykind-projector:underscores compatiblity mode#12378
Merged
smarter merged 1 commit intoscala:masterfrom May 10, 2021
Merged
Conversation
Contributor
Author
|
Note: #5379 is not fully addresssed because there is an unresolved question on what should SIP mentions that analogy with value-level placeholders is a reason to use However, in Scala 2 kind-projector will translate the above to Therefore this change repurposes Ykind-projector machinery to allow cross-compilation with a subset of new syntax and leaves the above question to a future 'proper' implementation of the SIP. |
9724934 to
196868c
Compare
…es` compatiblity mode Also allow through `+_` and `-_` only in that mode, these variance markers are ignored since we infer variance.
196868c to
362786b
Compare
smarter
approved these changes
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also allow through
+_and-_only in that mode, these variance markers are ignored since we infer variance.Fix partially #5379
Related issues and PRs: typelevel/kind-projector#120 typelevel/kind-projector#188 scala/scala#9605
note
What I did in
Settings.scalato allow-Ykind-projectorto parse without an argument is likely suboptimal, but at least it's a very small diff...