ram_pcd_message: pass libff::bit_vector by const reference to avoid copies#224
Open
MozirDmitriy wants to merge 2 commits intoscipr-lab:masterfrom
Open
ram_pcd_message: pass libff::bit_vector by const reference to avoid copies#224MozirDmitriy wants to merge 2 commits intoscipr-lab:masterfrom
MozirDmitriy wants to merge 2 commits intoscipr-lab:masterfrom
Conversation
MozirDmitriy
commented
Sep 4, 2025
MozirDmitriy
commented
- Replace pass-by-value with const references for bit_vector parameters in ram_pcd_message constructor (root_initial, root, cpu_state, cpu_state_initial).
- Eliminates unnecessary copies while preserving API behavior and call sites.
- Aligns with prevalent codebase style where bit vectors are passed by const reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.