Using custom @screeps/common fork to avoid restarting common/storage process#35
Draft
brisberg wants to merge 3 commits into
Draft
Using custom @screeps/common fork to avoid restarting common/storage process#35brisberg wants to merge 3 commits into
brisberg wants to merge 3 commits into
Conversation
brisberg
force-pushed
the
incomplete-cleanup-custom-common
branch
from
f155ea2 to
bdce4b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#30 Fixes
I am using a forked version of @screeps/common which avoids printing console errors on connection failure and avoid restarting the connection socket on connection end.
This allows the
common/storageto actually end when the test cleans up.screeps/common@master...brisberg:no-storage-restart
I will work on preparing the change to @screeps/common as a clean change, but this will work for the moment.
Let me know what you think.