Skip to content

fix: tls version limit for rustls #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanmonstar merged 1 commit into from
Mar 23, 2024
Merged

fix: tls version limit for rustls #2203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/async_impl/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,9 +551,14 @@ impl ClientBuilder {
});
}

if versions.is_empty() {
return Err(crate::error::builder("empty supported tls versions"));
}

// Build TLS config
let config_builder =
rustls::ClientConfig::builder().with_root_certificates(root_cert_store);
rustls::ClientConfig::builder_with_protocol_versions(&versions)
.with_root_certificates(root_cert_store);

// Finalize TLS config
let mut tls = if let Some(id) = config.identity {
Expand Down Expand Up @@ -1475,6 +1480,9 @@ impl ClientBuilder {
/// isn't supported, just that it can't be set as a maximum due to
/// technical limitations.
///
/// Cannot set a maximum outside the protocol versions supported by
/// `rustls` with the `rustls-tls` backend.
///
/// # Optional
///
/// This requires the optional `default-tls`, `native-tls`, or `rustls-tls(-...)`
Expand Down
⚡