Update bootstrap for HTML coverage to version 4#644
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:masterfrom Oct 14, 2018
rpkamp:bootstrap4
Merged
Update bootstrap for HTML coverage to version 4#644sebastianbergmann merged 1 commit intosebastianbergmann:masterfrom rpkamp:bootstrap4
sebastianbergmann merged 1 commit intosebastianbergmann:masterfrom
rpkamp:bootstrap4
Conversation
rpkamp
commented
Oct 13, 2018
| \copy($this->templatePath . 'css/nv.d3.min.css', $dir . 'nv.d3.min.css'); | ||
| \copy($this->templatePath . 'css/style.css', $dir . 'style.css'); | ||
| \copy($this->templatePath . 'css/custom.css', $dir . 'custom.css'); | ||
| \copy($this->templatePath . 'css/octicons.css', $dir . 'octicons.css'); |
Contributor
Author
There was a problem hiding this comment.
Glyphicons is no longer part of bootstrap, so I opted for octicons from Github instead because:
- It's smaller, just some small SVG files instead of large font files
- The icons are a bit nicer and most programmers should be familiar with them as GitHub uses them as well
rpkamp
commented
Oct 13, 2018
| <title>Dashboard for {{full_path}}</title> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <link href="{{path_to_root}}.css/bootstrap.min.css" rel="stylesheet" type="text/css"> | ||
| <link href="{{path_to_root}}.css/bootstrap.min.css?v=4.1.3" rel="stylesheet" type="text/css"> |
Contributor
Author
There was a problem hiding this comment.
The ?v= everywhere are used for cache bursting in case people serve this from a web server that's caching (too) aggressively.
There was a problem hiding this comment.
I would rather not have ?v=, to be honest.
Contributor
Author
There was a problem hiding this comment.
What would you like instead? Getting the new HTML with the old CSS / JS is not going to work.
There was a problem hiding this comment.
I trust people to be smart enough to force-reload in case the rendered report looks broken.
Contributor
Author
There was a problem hiding this comment.
Okay fair enough. I'll remove it.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
Previous (bootstrap 3) for this same page for reference: