Throw an exception if code coverage fails to write to disk#700
Closed
duncan3dc wants to merge 1 commit intosebastianbergmann:8.0from
Closed
Throw an exception if code coverage fails to write to disk#700duncan3dc wants to merge 1 commit intosebastianbergmann:8.0from
duncan3dc wants to merge 1 commit intosebastianbergmann:8.0from
Conversation
0dda461 to
23c3be9
Compare
Codecov Report
@@ Coverage Diff @@
## 8.0 #700 +/- ##
============================================
+ Coverage 82.29% 83.84% +1.55%
- Complexity 832 856 +24
============================================
Files 37 39 +2
Lines 2496 2538 +42
============================================
+ Hits 2054 2128 +74
+ Misses 442 410 -32
Continue to review full report at Codecov.
|
23c3be9 to
dd45785
Compare
999abec to
67341a5
Compare
Owner
|
This pull request has conflicts that must be resolved. Please update your pull request and base it on the |
Owner
|
Merged manually, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm experiencing the same issue as #692 (seems to the
\SoapClientcausing some issues).I traced the error to this
\DomDocument#save()call.This PR adds error checking to that call, so that at least the issue is reported.
Before:
After: