--exclude is not working properly and not documented

[vemod]

consider src/tests, src/something/deeper/tests

phpcpd --exclude tests src/

will exclude not only src/tests but all occurrences of tests, means src/something/deeper/tests also will be excluded.

Spent already an hour trying to figure out how to exclude src/tests, but not src/something/deeper/tests/

I tried absalute path, relative path, path patterns, with quotes, without quotes etc.. none of the ways lets me do that.

phpcpd 1.4.3 by Sebastian Bergmann.

Usage: phpcpd [switches] <directory|file> ...
...
  --exclude <dir>          Exclude <dir> from code analysis.

Sad that Sebastian Bergmann has so poorly documented this tool.

[gcrico]

The exclude option is handled by :
https://github.com/symfony/Finder/blob/2.2/Iterator/ExcludeDirectoryFilterIterator.php
This is the "poorly documented" component to blame ;-)

I agree that the exclude options should have a better behavior (and make easy to exclude first level dirs).
But some folks may need backward compat!
So we should add a new option.

Maybe a "--exclude-pattern" that would accept a regexp (hey this is a dev tool!), ran on the filename canonicalized relatively to the current working directory ?
ex:

# would exclude "src/tests/*" but not "src/something/deeper/tests/*"
phpcpd --exclude-pattern="#^src/tests/#" src

# would exclude any "*/tests/*"
phpcpd --exclude-pattern="#/tests/#" src

[jian-wu]

Hi guys, any update on a fix for this? Thanks.

[sebastianbergmann]

Should have been taken care of by #100.