This repository was archived by the owner on Jan 10, 2023. It is now read-only.
[RFR] Add a regexps-exclude option#100
Merged
sebastianbergmann merged 1 commit intosebastianbergmann:masterfrom Jan 24, 2017
Merged
[RFR] Add a regexps-exclude option#100sebastianbergmann merged 1 commit intosebastianbergmann:masterfrom
sebastianbergmann merged 1 commit intosebastianbergmann:masterfrom
Conversation
|
👍 |
|
👍 |
Contributor
Author
|
@sebastianbergmann Any news for this one? :) |
|
👍 |
7 similar comments
|
👍 |
|
👍 |
|
👍 |
|
👍 |
|
👍 |
|
👍 |
|
👍 |
|
👍 |
1 similar comment
|
👍 |
|
: +1 : |
|
👍 |
1 similar comment
|
👍 |
Owner
|
Thank you for your contribution. Sorry that it took so long to merge your pull request. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--regexps-excludeoption to counter a limitation with other options.The
--names-excludeoption refers only to base name, which forbids to exclude a given path. For instance, if we want to excludeweb/app_*.phpit will not work. We have to excludeapp_*.phpthrough the--names-exclude. But it will also excludesrc/app_test.phpfor instance.The
--regexps-excludeallows to specify a regexp which will then be inserted into thenotPathmethod of the finder (a PR on finder-facade has been created). This way, we can exclude previous patterns with a command line such:phpcpd.phar --regexps-exclude '~web/app_.*\.php~' myProjectThis PR can probably helps to fix some issues with the
--excludeoption, and should be an answer to #84.