--no-extensions CLI option only prevents extension PHARs from being loaded

[wickedOne]

Q	A
PHPUnit version	9.5.25
PHP version	8.1
Installation Method	Composer

Summary

the --no-extensions cli option does not apply to the <extension> element configured in the phpunit.xml

Current behavior

while passing the --no-extensions cli option, extensions configured in the extension element of phpunit.xml are loaded when running phpunit.

i'm not sure whether this is intended behaviour or an oversight tho (happens here)

phpunit/src/TextUI/Configuration/Merger.php

Lines 164 to 183 in 6770c48

	$loadPharExtensions = true;
	if ($cliConfiguration->hasNoExtensions() && $cliConfiguration->noExtensions()) {
	$loadPharExtensions = false;
	}
	$pharExtensionDirectory = null;
	if ($xmlConfiguration->phpunit()->hasExtensionsDirectory()) {
	$pharExtensionDirectory = $xmlConfiguration->phpunit()->extensionsDirectory();
	}
	$extensionBootstrappers = [];
	foreach ($xmlConfiguration->extensions() as $extension) {
	$extensionBootstrappers[] = [
	'className' => $extension->className(),
	'parameters' => $extension->parameters(),
	];
	}

How to reproduce

minimal, self-contained test case to reproduce can be found over here

Expected behavior

the extensions configured in the extension element are not loaded like the ones from the pharDirectory

[wickedOne]

thank you @sebastianbergmann !

[nightio]

@sebastianbergmann It's not working on version 9.x (at least) as it still seems to have the same issue. Upon checking the code, I noticed that the $this->arguments variable used isn't defined. There is no $this->arguments variable, only $arguments. Please refer to this link for more details:

phpunit/src/TextUI/TestRunner.php

Line 1009 in 241c4aa

if (!isset($this->arguments['noExtensions'])) {

I tried fixing it locally, and when I replaced the undefined variable with $arguments, it worked correctly under both scenarios: when the option is provided in the CLI - the extensions are not loaded. Conversely, if the option is not provided, the extensions are loaded.

Could you take a look and possibly make this fix?

[sebastianbergmann]

Could you take a look and possibly make this fix?

Please open a new issue, thanks.