Performance regression in PHPUnit 11.5.54, PHPUnit 12.5.13, and PHPUnit 13.0.4

[arjan-12b]

Q	A
PHPUnit version	11.5.54
PHP version	8.4.17
Installation Method	Composer

Summary

After updating phpunit to version 11.5.54, tests are extremely slow. Running phpunit on version 11.5.53, tests are running as expected.

Current behavior

Tests are slow, can take sometimes up to 20 sec, when it passed before with ~100ms. This also leads to memory issues.

How to reproduce

Update to version 11.5.54 and run a test.

Expected behavior

Test should be as fast as before version 11.5.54.

[sebastianbergmann]

The only change between PHPUnit 11.5.53 and PHPUnit 11.5.54 is #6489.

@stof Do you have an idea why #6489 would cause such a performance regression?

[staabm]

@arjan-12b could you provide a reproducer?

[stof]

@sebastianbergmann without profiling data, my only idea would be that the call to SourceFilter::instance() in the ErrorHandler constructor might be the issue (also because I saw #6493).
In the old code, SourceFilter::instance() was called only when enabling the identification of deprecations and a deprecation was triggered. Maybe the initialization of $this->sourceFilter should be delayed (or removing the instance property entirely as SourceFilter::instance() already manages a singleton)

[sebastianbergmann]

Please test whether this change to src/Runner/ErrorHandler.php solves your problem:

diff --git a/src/Runner/ErrorHandler.php b/src/Runner/ErrorHandler.php
index d093a4b36..e5359b729 100644
--- a/src/Runner/ErrorHandler.php
+++ b/src/Runner/ErrorHandler.php
@@ -56,7 +56,6 @@ final class ErrorHandler
     private static ?self $instance      = null;
     private ?Baseline $baseline         = null;
     private ExcludeList $excludeList;
-    private SourceFilter $sourceFilter;
     private bool $enabled                     = false;
     private ?int $originalErrorReportingLevel = null;
     private readonly bool $identifyIssueTrigger;
@@ -86,7 +85,6 @@ public static function instance(): self
     private function __construct(bool $identifyIssueTrigger)
     {
         $this->excludeList          = new ExcludeList;
-        $this->sourceFilter         = SourceFilter::instance();
         $this->identifyIssueTrigger = $identifyIssueTrigger;
     }
 
@@ -324,7 +322,7 @@ private function categorizeFile(string $file, TestMethod $test): Code
             return Code::Test;
         }
 
-        if ($this->sourceFilter->includes($file)) {
+        if (SourceFilter::instance()->includes($file)) {
             return Code::FirstParty;
         }

[arjan-12b]

Yes, that fixes the issue for me 👍🏻.