Skip to content
This repository was archived by the owner on Jun 23, 2025. It is now read-only.

feat: add gestureHandling attirbute to MapOptions#919

Closed
jimulle wants to merge 1 commit into
sebholstein:masterfrom
jimulle:gestureHandling
Closed

feat: add gestureHandling attirbute to MapOptions#919
jimulle wants to merge 1 commit into
sebholstein:masterfrom
jimulle:gestureHandling

Conversation

@jimulle

@jimulle jimulle commented Mar 6, 2017

Copy link
Copy Markdown
Contributor

The gestureHandling attribute in MapOptions controls how
gestures on the map are handled. The attribute takes one
of four string values (cooperative, greedy, none and auto).

Changes are not breaking, gestureHandling is an optional
attribute and the google maps api defaults this attribute to
'auto'.

The gestureHandling attribute in MapOptions controls how
gestures on the map are handled. The attribute takes one
of four string values (cooperative, greedy, none and auto).

Changes are not breaking, gestureHandling is an optional
attribute and the google maps api defaults this attribute to
'auto'.
@GitCop

GitCop commented Mar 6, 2017

Copy link
Copy Markdown

There were the following issues with your Pull Request

  • Commit: 5f20605
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@sebholstein sebholstein left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gestureHandling is missing in the inputs configuration.

* 'greedy' (All touch gestures pan or zoom the map.)
* 'none' (The map cannot be panned or zoomed by user gestures.)
* 'auto' [default] (Gesture handling is either cooperative or greedy, depending on whether the page is scrollable or not.
*/

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change it to this for better autocompletion?:

gestureHandling: 'cooperative'|'greedy'|'none'|'auto' = 'auto';

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed the comments but I am now getting an issue with the webpack config when running the tests:

> karma start

12 03 2017 14:45:47.938:ERROR [preprocess]: Can not load "webpack"!
  WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.entry should be one of these:
   object { <key>: non-empty string | [non-empty string] } | non-empty string | [non-empty string] | function
   The entry point(s) of the compilation.
   Details:
    * configuration.entry should NOT have less than 1 properties ({
        "keyword": "minProperties",
        "dataPath": ".entry",
        "schemaPath": "#/oneOf/0/minProperties",
        "params": {
          "limit": 1
        },
        "message": "should NOT have less than 1 properties",
        "schema": 1,
        "parentSchema": {
          "minProperties": 1,
          "additionalProperties": {
            "oneOf": [
              {
                "description": "The string is resolved to a module which is loaded upon startup.",
                "minLength": 1,
                "type": "string"
              },
              {
                "description": "All modules are loaded upon startup. The last one is exported.",
                "$ref": "#/definitions/common.nonEmptyArrayOfUniqueStringValues"
              }
            ]
          },
          "description": "Multiple entry bundles are created. The key is the chunk name. The value can be a string or an array.",
          "type": "object"
        },
        "data": {}
      }).
      object { <key>: non-empty string | [non-empty string] }
      Multiple entry bundles are created. The key is the chunk name. The value can be a string or an array.
    * configuration.entry should be a string.
    * configuration.entry should be an array:
      [non-empty string]
    * configuration.entry should be an instance of function
      function returning an entry object or a promise..
    at webpack (/Users/jimulle/Desktop/angular2-google-maps/node_modules/webpack/lib/webpack.js:19:9)
    at new Plugin (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma-webpack/lib/karma-webpack.js:63:18)
    at invoke (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:75:15)
    at Array.instantiate (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:59:20)
    at get (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:48:43)
    at /Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:71:14
    at Array.map (native)
    at Array.invoke (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:70:31)
    at Injector.get (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:48:43)
    at instantiatePreprocessor (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma/lib/preprocessor.js:55:20)
    at Array.forEach (native)
    at createPreprocessor (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma/lib/preprocessor.js:74:20)
    at Array.invoke (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:75:15)
    at get (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:48:43)
    at /Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:71:14
    at Array.map (native)
    at Injector.invoke (/Users/jimulle/Desktop/angular2-google-maps/node_modules/di/lib/injector.js:70:31)
    at Server.start (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma/lib/server.js:103:18)
    at Object.exports.run (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma/lib/cli.js:280:26)
    at Object.<anonymous> (/Users/jimulle/Desktop/angular2-google-maps/node_modules/karma/bin/karma:3:23)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)

START:
12 03 2017 14:45:47.974:INFO [karma]: Karma v1.3.0 server started at http://localhost:9876/
12 03 2017 14:45:47.975:INFO [launcher]: Launching browser Chrome with unlimited concurrency
12 03 2017 14:45:47.976:ERROR [karma]: Found 1 load error

@jimulle jimulle Mar 12, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same issue being reported by @demianh in his pull request: #923

@sebholstein

Copy link
Copy Markdown
Owner

@jimulle thx! Can you address the comments?

@sebholstein

Copy link
Copy Markdown
Owner

@jimulle the build process is now fixed. I will try to make the changes and merge your PR

@jimulle

jimulle commented Mar 28, 2017

Copy link
Copy Markdown
Contributor Author

I will rebase and update the PR tonight

@sebholstein

Copy link
Copy Markdown
Owner

@jimulle I've done it for you 😃 changed some little details but your contribution remains.

@sebholstein

Copy link
Copy Markdown
Owner

thx for your time!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants