[Task Runner API] [Flower Interoperability] Integrate changes for flower-app-pytorch workspace's custom Aggregator into core component#1585
Merged
kminhta merged 7 commits intosecurefederatedai:developfrom May 2, 2025
Conversation
Signed-off-by: kta-intel <kevin.ta@intel.com>
kminhta
requested review from
MasterSkepticista,
psfoley and
teoparvanov
as code owners
Signed-off-by: kta-intel <kevin.ta@intel.com>
teoparvanov
approved these changes
May 2, 2025
Collaborator
teoparvanov
left a comment
teoparvanov
left a comment
There was a problem hiding this comment.
Looks great, thanks @kta-intel !
rahulga1
approved these changes
May 2, 2025
Signed-off-by: kta-intel <kevin.ta@intel.com>
Signed-off-by: kta-intel <kevin.ta@intel.com>
Signed-off-by: kta-intel <kevin.ta@intel.com>
payalcha
pushed a commit
to payalcha/openfl
that referenced
this pull request
May 6, 2025
…ower-app-pytorch` workspace's custom `Aggregator` into core component (securefederatedai#1585) * integrate custom flwr workspace aggregator to core aggregator Signed-off-by: kta-intel <kevin.ta@intel.com> * formatting Signed-off-by: kta-intel <kevin.ta@intel.com> * change self.use_connector > self.interop_mode Signed-off-by: kta-intel <kevin.ta@intel.com> * docstring for connector Signed-off-by: kta-intel <kevin.ta@intel.com> * formatting Signed-off-by: kta-intel <kevin.ta@intel.com> --------- Signed-off-by: kta-intel <kevin.ta@intel.com> Co-authored-by: teoparvanov <teodor.parvanov@intel.com> Signed-off-by: Chaurasiya, Payal <payal.chaurasiya@intel.com>
2 tasks
tayfunceylan
pushed a commit
to tayfunceylan/openfl
that referenced
this pull request
May 23, 2025
…ower-app-pytorch` workspace's custom `Aggregator` into core component (securefederatedai#1585) * integrate custom flwr workspace aggregator to core aggregator Signed-off-by: kta-intel <kevin.ta@intel.com> * formatting Signed-off-by: kta-intel <kevin.ta@intel.com> * change self.use_connector > self.interop_mode Signed-off-by: kta-intel <kevin.ta@intel.com> * docstring for connector Signed-off-by: kta-intel <kevin.ta@intel.com> * formatting Signed-off-by: kta-intel <kevin.ta@intel.com> --------- Signed-off-by: kta-intel <kevin.ta@intel.com> Co-authored-by: teoparvanov <teodor.parvanov@intel.com> Signed-off-by: Tayfun Ceylan <tayfun.ceylan>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flower-app-pytorchworkspace was originally written to be as self-contained as possible, this included its own custom aggregator that subclassed the coreAggregator. This PR cleans up and pulls these features back into the coreAggregatorThis is part of a larger effort to pull custom workspace code back to the core OpenFL for better maintainability and for more native support of Flower workloads. This is being done piecewise as they are not interdependent and it'll be easier to track and control individual component changes.
Type of Change (Mandatory)
Specify the type of change being made.
Description (Mandatory)
This PR:
openfl-workspace/flower-app-pytorch/src/aggregator.pyconnector input andself.connectorattribute to the coreAggregator`self.connectorin order to:self.modelas an empty dict since we will allow Flower apps handle the "inner" experiment at this stageTesting
Manual testing