Fix HiggsDataLoader due to missing class methods#1641
Merged
rahulga1 merged 1 commit intosecurefederatedai:developfrom May 20, 2025
Merged
Fix HiggsDataLoader due to missing class methods#1641rahulga1 merged 1 commit intosecurefederatedai:developfrom
rahulga1 merged 1 commit intosecurefederatedai:developfrom
Conversation
This update introduces two new methods, `get_feature_shape` and `get_num_classes`, to the HiggsDataLoader class. These methods provide easy access to the feature shape and the number of classes for the Higgs dataset, enhancing the usability of the data loader. Signed-off-by: Rahul Garg <rahul.garg@intel.com>
rahulga1
requested review from
MasterSkepticista,
kminhta,
psfoley and
teoparvanov
as code owners
rahulga1
changed the title
payalcha
reviewed
May 20, 2025
Collaborator
payalcha
left a comment
payalcha
left a comment
There was a problem hiding this comment.
Tested the cahnges its working as expected.
tayfunceylan
pushed a commit
to tayfunceylan/openfl
that referenced
this pull request
May 23, 2025
…ederatedai#1641) This update introduces two new methods, `get_feature_shape` and `get_num_classes`, to the HiggsDataLoader class. These methods provide easy access to the feature shape and the number of classes for the Higgs dataset, enhancing the usability of the data loader. Signed-off-by: Rahul Garg <rahul.garg@intel.com> Signed-off-by: Tayfun Ceylan <tayfun.ceylan>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added required methods to make it compatible.
Type of Change (Mandatory)
Specify the type of change being made.
Description (Mandatory)
missed adding required methods for Higgs dataloader class
Testing
Locally testing.