Skip to content

Rename LegacySettings to CDNSettings#1088

Merged
silesky merged 7 commits intomasterfrom
make-names-less-confusing
May 14, 2024
Merged

Rename LegacySettings to CDNSettings#1088
silesky merged 7 commits intomasterfrom
make-names-less-confusing

Conversation

@silesky
Copy link
Copy Markdown
Contributor

@silesky silesky commented May 13, 2024

As someone who was once new to the codebase, this single-handedly was one of the most confusing parts of the API. There is nothing legacy about these settings, and they have no particular special relationship to LegacyDestination.

@silesky silesky requested a review from danieljackins May 13, 2024 20:13
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 9a94422

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant