Skip to content

Add analytics.settings api#1090

Merged
silesky merged 7 commits intomasterfrom
add-config-to-analytics
May 22, 2024
Merged

Add analytics.settings api#1090
silesky merged 7 commits intomasterfrom
add-config-to-analytics

Conversation

@silesky
Copy link
Copy Markdown
Contributor

@silesky silesky commented May 21, 2024

Adding an analytics.settings API so that plugins can have read access to the CDNSettings. This is more of an escape valve, and does not mean the CDNSettings is suddenly an official stable and publicly-documented object.

Also, removes the accidental loadLegacySettings from exports, since it's not a public API.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: c95d99d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky force-pushed the add-config-to-analytics branch 2 times, most recently from bd1ffd5 to 486b9a2 Compare May 21, 2024 20:38
@silesky silesky force-pushed the add-config-to-analytics branch from 486b9a2 to 3be7b87 Compare May 21, 2024 20:43
@silesky silesky merged commit b611746 into master May 22, 2024
@silesky silesky deleted the add-config-to-analytics branch May 22, 2024 00:03
@github-actions github-actions bot mentioned this pull request May 22, 2024
laksh-twilio added a commit that referenced this pull request Apr 15, 2026
  Fixes #1336

  NullAnalytics was accidentally removed from the public exports in
  commit b611746 (PR #1090) when exports were changed from wildcard
  to explicit. This restores the export for users who need NullAnalytics
  in their test code.
@github-actions github-actions bot mentioned this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants