Fix conflict between window.analytics AND npm library in same scope.#1127
Merged
Fix conflict between window.analytics AND npm library in same scope.#1127
Conversation
🦋 Changeset detectedLatest commit: 7275822 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
changed the title
silesky
changed the title
silesky
changed the title
danieljackins
approved these changes
Aug 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partly addresses: #785, so we don't read buffered window.analytics events in the npm version.
Now we support using both a snippet version of analytics and a separate npm version of analytics instance (different writeKeys) in the same scope, and they shouldn't clobber eachother.
No need for
globalAnalyticsKey: 'SEG_DISABLE'workaround.For posterity, there is an existing gap is around if a user needs to override the global cdn on a specific instance.
This drops support for the implicit behavior described in #390