Conversation
🦋 Changeset detectedLatest commit: b5c46ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
force-pushed
the
chore/refactor-tsconfig-to-better-separate-build
branch
from
ec25e44 to
931660d
Compare
silesky
force-pushed
the
chore/refactor-tsconfig-to-better-separate-build
branch
from
931660d to
f8cae58
Compare
silesky
force-pushed
the
chore/refactor-tsconfig-to-better-separate-build
branch
from
52f4dae to
603d944
Compare
Merged
silesky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate a
typesfolder inbrowser, similar to the rest of the packages.reference tsconfig.build.json in webpack, which is the correct tsconfig to reference.
include src and declaration maps to improve IDE experience.
fix sourcemap warning in core.
make tsconfig and tsconfig.build.json consistent across packages -- tsconfig.build.json will be a build configuration; therefore, it has an
outDirandtypesDirand be responsible for specifics around generating thedistfolder.tsconfig.jsonis a base tsconfig and should contains information around the overall environment (e.g. target, libs), with enough info run lint / jest / etc correctly without building a dist folder or generating declarations.