Skip to content

use object rather than JSON type#578

Merged
silesky merged 2 commits intomasterfrom
loosen-segment-event-type-more
Aug 10, 2022
Merged

use object rather than JSON type#578
silesky merged 2 commits intomasterfrom
loosen-segment-event-type-more

Conversation

@silesky
Copy link
Copy Markdown
Contributor

@silesky silesky commented Aug 10, 2022

See: #575 (comment). This is a valid pattern, and it's better to have false negatives (missing TS errors) over false positives.

@silesky silesky requested review from chrisradek and pooyaj August 10, 2022 22:03
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 10, 2022

🦋 Changeset detected

Latest commit: 5ba276f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky force-pushed the loosen-segment-event-type-more branch from c6a1f5f to ce252c3 Compare August 10, 2022 22:13
@silesky silesky enabled auto-merge (squash) August 10, 2022 22:21
@silesky silesky disabled auto-merge August 10, 2022 22:32
@silesky silesky merged commit ab8cea3 into master Aug 10, 2022
@silesky silesky deleted the loosen-segment-event-type-more branch August 10, 2022 22:32
@github-actions github-actions bot mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant